Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FitRWMWaveform to Unity + Factory #326

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Add FitRWMWaveform to Unity + Factory #326

merged 2 commits into from
Dec 16, 2024

Conversation

S81D
Copy link
Contributor

@S81D S81D commented Dec 16, 2024 •
edited
Loading

Describe your changes

In PR #289 I forgot to add the tool to Factory + Unity. We noticed in the PrintDQ tool that we were getting 0% of events with a BRF fit - i suspect its because the FitRWMWaveform tool was never compiled / built.

Checklist before submitting your PR

  • This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • This PR alters the minimum number of files to affect this change
  • [N/A] If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • [N/A] If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • [N/A] For every new usage, there is a reason the data must be on the heap
  • [N/A] For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Additional Material

@S81D
Copy link
Contributor Author

S81D commented Dec 16, 2024

Testing shows this fixes the problem:

Running the PrintDQ toolchain over processed data (5138) using the main repository we get the following statistic:

[1]: **************************************
[1]: Run 5138
[1]: **************************************
[1]: 
[1]: has BRF fit:          0    (0% +/- 0%)

With the corrections to Unity and Factory, running over a handful of the same processed files the issue is resolved:

[1]: **************************************
[1]: Run 5138
[1]: **************************************
[1]: has BRF fit:          16709    (99.4287% +/- 1.08625%)

@marc1uk marc1uk merged commit 968f02d into ANNIEsoft:Application Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S81D @marc1uk